Skip to content

chore: followup on MessageSource/MessageSuggestion from testing#10178

Merged
yihuiliao merged 6 commits into
mainfrom
ai-components-follw-up-again
Jun 12, 2026
Merged

chore: followup on MessageSource/MessageSuggestion from testing#10178
yihuiliao merged 6 commits into
mainfrom
ai-components-follw-up-again

Conversation

@yihuiliao

@yihuiliao yihuiliao commented Jun 9, 2026

Copy link
Copy Markdown
Member

Follow up #10095

  • Removes the isPressed background color from MessageSuggestion
  • Fixes press scaling for Message Suggestion
  • The number badges in a MessageSourceList respond to t-shirt sizing (not sure if design even support t-shirt sizing for these components but an easy enough fix so I've added it)
  • Adds hover state to ResponseStatus (the style could be debated. it might be feel strange that the checkmark is not aligned at the end of the button which is only obvious once you hover over the disclosure).

Things still to resolve:
Should we use UI icons for the chevron in ResponseStatus

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

  • Removes the isPressed background color from MessageSuggestion
  • Fixes press scaling for Message Suggestion so it should transition
  • The number badges in a MessageSourceList respond to t-shirt sizing
  • Adds hover state to ResponseStatus

🧢 Your Project:

@github-actions github-actions Bot added the v3 label Jun 9, 2026
@rspbot

rspbot commented Jun 9, 2026

Copy link
Copy Markdown

Comment thread .github/labeler.yml Outdated
- changed-files:
- all-globs-to-any-file: ['**/@react-spectrum/**', '!**/*.stories.*', '!**/*.test.*']
- all-globs-to-all-files: '!**/@react-spectrum/s2/**'
- all-globs-to-all-files: ['!**/@react-spectrum/s2/**', '!**/@react-spectrum/s2-ai/**']

@yihuiliao yihuiliao Jun 9, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems like the labeler is mislabeling these changes as v3 bc they're under @react-spectrum. this updates the labeler to exclude labeling anything under ai as v3 (hopefully)

@rspbot

rspbot commented Jun 9, 2026

Copy link
Copy Markdown

@yihuiliao yihuiliao removed the v3 label Jun 9, 2026
reidbarber
reidbarber previously approved these changes Jun 9, 2026
@rspbot

rspbot commented Jun 12, 2026

Copy link
Copy Markdown

@yihuiliao yihuiliao added this pull request to the merge queue Jun 12, 2026
Merged via the queue into main with commit 832519e Jun 12, 2026
30 checks passed
@yihuiliao yihuiliao deleted the ai-components-follw-up-again branch June 12, 2026 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants