Skip to content

fix(ew-actions): flush collab writes before preview/publish #604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
hannessolo wants to merge 2 commits into
base: main
Choose a base branch
from
+24 −0
Draft

fix(ew-actions): flush collab writes before preview/publish #604

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cc660fb
fix(ew-actions): flush collab writes before preview/publish
hannessolo Jul 15, 2026
3d25833
fix(ew-actions): load dialog deps before setting error state
hannessolo Jul 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions nx2/blocks/ew-actions/ew-actions.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,6 +163,30 @@ class NXEwActions extends LitElement {
this._dialog = undefined;
this._busy = true;

// Flush pending collab updates to da-admin before AEM reads it,
// otherwise the last ~2s of edits (held in da-collab's debounce) are missed.
const editorDoc = document.querySelector('ew-editor-doc');
if (editorDoc?.forceSave) {
const flushResult = await editorDoc.forceSave();
if (!flushResult?.ok) {
await Promise.all([
import('../shared/dialog/dialog.js'),
import(`${NX_BASE}/public/sl/components.js`),
]);
this._busy = false;
this._hasError = true;
this._dialog = {
phase: 'error',
error: {
action,
type: 'error',
message: flushResult?.error || 'Unable to confirm save. Please retry or reload the editor.',
},
};
return;
}
}

const result = await runAemPreviewOrPublish({ aemPath, action });
if (!result.ok) {
await Promise.all([
Expand Down
Loading