Conversation
- source.copyFolder mirrors copy/createFolder/deleteFolder conventions - hlx6 normalizes path/destination to a trailing slash before dispatch - legacy DA uses path/destination as-is (da-admin doesn't need the slash) - update api.d.ts and api.md docs - add unit tests covering hlx6, legacy, and path-string calling forms
mhaack
changed the title
mhaack
requested review from
bosschaert,
chrischrischris,
hannessolo,
kptdobe and
sharanyavinod
July 13, 2026 09:49
sharanyavinod
approved these changes
Jul 14, 2026
hannessolo
approved these changes
Jul 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
source.copyFoldertonx2/utils/api.js, mirroring the existingcopy/createFolder/deleteFolderconventions so callers can recursively copy a folder rather than a single document.path/destinationto a trailing slash before PUTing to the destination URL with?source=…&collision=…query params.path/destinationas-is (no trailing-slash normalization needed — handled by da-admin) and POSTs to/copy/{org}/{site}{path}with amultipart/form-datadestinationfield.This PR is needed for adobe/da-live#1092
Changes
nx2/utils/api.js— newsource.copyFoldermethod.nx2/utils/api.d.ts— type signature + doc comment.nx2/utils/api.md— method table row, URL-shapes row, and usage example.test/nx2/utils/api.test.js— unit tests covering hlx6, legacy, trailing-slash normalization, and path-string calling forms.Testing
npx web-test-runner test/nx2/utils/api.test.js— all tests pass.npm test) — 1031 passed, 0 failed.