feat(ew): sync layout-mode block & image selection with the doc#1114
Open
usman-khalid wants to merge 2 commits into
Open
feat(ew): sync layout-mode block & image selection with the doc#1114usman-khalid wants to merge 2 commits into
usman-khalid wants to merge 2 commits into
Conversation
sharanyavinod
previously approved these changes
Jul 16, 2026
sharanyavinod
left a comment
Contributor
There was a problem hiding this comment.
Thank you for the contribution!
Looks good, just a nit: would be nice to cleanup the comments where possible or make them more concise.
sharanyavinod
approved these changes
Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should be merged with adobe/da-nx#605
Implements support to select blocks/images in canvas synced to doc and the outline panel.
Screen.Recording.2026-07-15.at.15.48.53.mov
Note on event system consistency: This PR adds one new postMessage pair (
set-selected-node/node-select) and one new consumer of the existingeditorSelectChangebus. Both follow current conventions, but I'm aware of SITES-46045 and if that lands while this is still open, happy to refactor as needed.