Skip to content

feat(ew): sync layout-mode block & image selection with the doc#1114

Open
usman-khalid wants to merge 2 commits into
mainfrom
canvsel
Open

feat(ew): sync layout-mode block & image selection with the doc#1114
usman-khalid wants to merge 2 commits into
mainfrom
canvsel

Conversation

@usman-khalid

@usman-khalid usman-khalid commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

Should be merged with adobe/da-nx#605

Implements support to select blocks/images in canvas synced to doc and the outline panel.

  • If in split mode, clicking a block in the outline panel scrolls down to it in both doc-mode and canvas.
  • Selecting a block in canvas retains the selection in doc-mode (and vice versa)
  • Selecting a block in canvas adds it to the chat context, same as doc-mode
  • Allows synced image selection between doc-mode and canvas
Screen.Recording.2026-07-15.at.15.48.53.mov

Note on event system consistency: This PR adds one new postMessage pair (set-selected-node / node-select) and one new consumer of the existing editorSelectChange bus. Both follow current conventions, but I'm aware of SITES-46045 and if that lands while this is still open, happy to refactor as needed.

@aem-code-sync

aem-code-sync Bot commented Jul 15, 2026

Copy link
Copy Markdown

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch.
In case there are problems, just click the checkbox below to rerun the respective action.

  • Re-sync branch
Commits

sharanyavinod
sharanyavinod previously approved these changes Jul 16, 2026

@sharanyavinod sharanyavinod left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution!

Looks good, just a nit: would be nice to cleanup the comments where possible or make them more concise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants