Skip to content

FORMS-23537 dir browser will only show browser and empty folder will …#239

Open
im-shiv wants to merge 1 commit into
adobe:mainfrom
im-shiv:FORMS-23537
Open

FORMS-23537 dir browser will only show browser and empty folder will …#239
im-shiv wants to merge 1 commit into
adobe:mainfrom
im-shiv:FORMS-23537

Conversation

@im-shiv

@im-shiv im-shiv commented May 8, 2026

Copy link
Copy Markdown

The Source Path and Target Path pickers in the Form Conversion job wizard had two issues:

  • Source Path: filter was hierarchyNotFile, which shows all content nodes including non-folder items. Changed to folder to show only folders, consistent with how forms are organized under /content/forms/af.
  • Target Path: rootPath was incorrectly set to /content/forms/af (same as source), and filter was hierarchyNotFile. The target for converted forms is the DAM path — changed rootPath to /content/dam/formsanddocuments and filter to folder.

Both pickers now browse the correct repository tree and surface only folder nodes.

@iamsudhanshu iamsudhanshu left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving - assuming you have validated the issue/use-case.

@bstopp bstopp left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Claude) Code Review — FORMS-23537

File changed: ui.apps/src/main/content/jcr_root/apps/aem-modernize/content/form/job/create/.content.xml

What this PR does

Updates the Forms job creation dialog's path picker fields:

  1. Changes both sourceRoot and targetRoot filters from hierarchyNotFilefolder
  2. Changes targetRoot's rootPath from /content/forms/af/content/dam/formsanddocuments

filter change (hierarchyNotFilefolder)

  • hierarchyNotFile shows folders and files in the picker tree; folder shows only folders. Since these fields are meant for picking a root path, folder is the correct and more restrictive choice — this is an improvement.
  • Inconsistency to note: The other job types (full, structure) still use hierarchyNotFile. If those pickers have the same intent, they may need the same fix.
  • A sibling node has a foundation-picker-control-src URL with filter=hierarchyNotFile hardcoded in its query string that was not updated in this PR. That picker may still show files when only folders are expected — worth a follow-up.

targetRoot path change

The original value (/content/forms/af) was clearly wrong — the target for adaptive forms output should be /content/dam/formsanddocuments. Straightforward bug fix with the correct value.


Issues

Severity Issue
Low foundation-picker-control-src on a sibling node still has filter=hierarchyNotFile in its query string — may be inconsistent with the updated picker behavior.
Low No test changes visible in the diff. If UI/IT tests cover this dialog, verify they pass with the new rootPath.

Summary

The changes are correct — they fix a real bug (wrong target root path) and improve UX (restrict picker to folders only). No blockers; the stale foundation-picker-control-src URL is worth a follow-up ticket.

@bstopp

bstopp commented May 29, 2026

Copy link
Copy Markdown
Contributor

@im-shiv - can you take a look at the siblings and determine if those should be changed as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants