FORMS-23537 dir browser will only show browser and empty folder will …#239
FORMS-23537 dir browser will only show browser and empty folder will …#239im-shiv wants to merge 1 commit into
Conversation
iamsudhanshu
left a comment
There was a problem hiding this comment.
Approving - assuming you have validated the issue/use-case.
bstopp
left a comment
There was a problem hiding this comment.
(Claude) Code Review — FORMS-23537
File changed: ui.apps/src/main/content/jcr_root/apps/aem-modernize/content/form/job/create/.content.xml
What this PR does
Updates the Forms job creation dialog's path picker fields:
- Changes both
sourceRootandtargetRootfilters fromhierarchyNotFile→folder - Changes
targetRoot'srootPathfrom/content/forms/af→/content/dam/formsanddocuments
filter change (hierarchyNotFile → folder)
hierarchyNotFileshows folders and files in the picker tree;foldershows only folders. Since these fields are meant for picking a root path,folderis the correct and more restrictive choice — this is an improvement.- Inconsistency to note: The other job types (
full,structure) still usehierarchyNotFile. If those pickers have the same intent, they may need the same fix. - A sibling node has a
foundation-picker-control-srcURL withfilter=hierarchyNotFilehardcoded in its query string that was not updated in this PR. That picker may still show files when only folders are expected — worth a follow-up.
targetRoot path change
The original value (/content/forms/af) was clearly wrong — the target for adaptive forms output should be /content/dam/formsanddocuments. Straightforward bug fix with the correct value.
Issues
| Severity | Issue |
|---|---|
| Low | foundation-picker-control-src on a sibling node still has filter=hierarchyNotFile in its query string — may be inconsistent with the updated picker behavior. |
| Low | No test changes visible in the diff. If UI/IT tests cover this dialog, verify they pass with the new rootPath. |
Summary
The changes are correct — they fix a real bug (wrong target root path) and improve UX (restrict picker to folders only). No blockers; the stale foundation-picker-control-src URL is worth a follow-up ticket.
|
@im-shiv - can you take a look at the siblings and determine if those should be changed as well? |
The Source Path and Target Path pickers in the Form Conversion job wizard had two issues:
Both pickers now browse the correct repository tree and surface only folder nodes.