Skip to content

Using list of characters instead of a string for Problem 24.8 #151#152

Open
deveshks wants to merge 1 commit intoadnanaziz:devfrom
deveshks:problem-24.8-improve-time-complexity
Open

Using list of characters instead of a string for Problem 24.8 #151#152
deveshks wants to merge 1 commit intoadnanaziz:devfrom
deveshks:problem-24.8-improve-time-complexity

Conversation

@deveshks
Copy link
Copy Markdown
Contributor

Updated code to use a list of characters instead of a string to represent an added word for Problem 24.8 in order to avoid the extra time complexity associated with string concatentations

$ python3.7 epi_judge_python_solutions/left_right_justify_text.py
Test PASSED (30/30) [ 15 us]
Average running time: 37 us

@deveshks
Copy link
Copy Markdown
Contributor Author

Hi @tsunghsienlee, @adnanaziz, @metopa

I have submitted a PR to outline my fix for issue #151.

Please review the same at your convenience and I will address any concerns with the same in the PR

@tsunghsienlee
Copy link
Copy Markdown
Collaborator

Generally it looks good to me, and I probably will omit get_strings function but it is definitely personal choice. This will be merge later.

@deveshks
Copy link
Copy Markdown
Contributor Author

deveshks commented May 9, 2020

Hi @tsunghsienlee

Hope you are doing well. I just saw that this PR has been sitting in an open state since a few months now. May I know when do you plan to merge this PR to master?

@metopa
Copy link
Copy Markdown
Collaborator

metopa commented Jun 7, 2020

@deveshks Hi there, sorry for the long wait. I'll check this out right after I do my state exams at the end of June. I'll keep you updated :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants