Skip to content

Fix std::sprintf build warnings#95

Open
mratzloff wants to merge 1 commit into
adishavit:masterfrom
mratzloff:fix-build-warnings
Open

Fix std::sprintf build warnings#95
mratzloff wants to merge 1 commit into
adishavit:masterfrom
mratzloff:fix-build-warnings

Conversation

@mratzloff

Copy link
Copy Markdown

No description provided.

Copy link
Copy Markdown
Owner

Thanks for the fix! We generally prefer not to patch vendored files in-place, as it creates silent divergence from upstream that gets overwritten on the next update.

Did you consider updating doctest.h to the latest release (v2.5.0, released March 27, 2025) instead? That would likely include this fix along with many others.

One concern worth checking first: argh targets C++11, and doctest v2.5.0 may have raised its minimum C++ standard requirement given the significant modernization work in that release. Do you know if v2.5.0 still supports C++11?


Generated by Claude Code

@a4z

a4z commented Mar 29, 2026

Copy link
Copy Markdown
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants