Module add#3
Open
rse2019coder wants to merge 7 commits into
Open
Conversation
added 7 commits
September 15, 2019 10:49
The input and output arguments are correct but it simply returns the value 0 for the moment.
Described in issue #2
adcwilliams
requested changes
Sep 15, 2019
adcwilliams
left a comment
adcwilliams
left a comment
Owner
There was a problem hiding this comment.
The Automated tests don't run successfully! I'm getting:
src/test_my_function.py:9: AssertionError
| displayName: 'Run a one-line script' | ||
| - task: UsePythonVersion@0 | ||
| inputs: | ||
| versionSpec: '3.7' |
Owner
There was a problem hiding this comment.
Does it work in version 3.7?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge request completing tasks described by Issue #2
Changes
my_function.pymoduleComments
The scope of the Issue does not cover adding additional functionality on top of the addition code, so I have limited myself to simply adding the framework for future arithmetical functions.