ci(ai-review): port Argus PR reviewer from adcp main#762
Open
bokelley wants to merge 1 commit into
Open
Conversation
Adds the Argus AI PR review workflow plus its prompt, adapted for the Python SDK's wire surface and toolchain. Adaptations vs upstream: - Trivial-paths list retargeted to docs/, examples/, tests/, generated types (src/adcp/types/generated_poc/**, _generated.py), schemas/. - MUST FIX rules dropped: spec drift on static/schemas/source/**, missing changeset, oneOf-walker regression — none apply here. - MUST FIX rules added: breaking public-API change without conventional- commit ! / BREAKING CHANGE: (release-please semver signal); type-system layering breach (non-stable modules importing from generated_poc/ or _generated.py) per CLAUDE.md; Pydantic discriminated-union regression (drops UnknownFormatAsset-style fallback, narrows additionalProperties, removes discriminator value); CI gate regression (disabled tests, blanket # type: ignore). - Coverage checks: schema-vs-docs audit replaced with public-API coherence audit + generated-type regeneration audit. - Expert triggers retargeted to src/adcp/types, src/adcp/protocols, src/adcp/decisioning, src/adcp/migrate, mypy plugin → python-expert. Uses IPR_APP_ID / IPR_APP_PRIVATE_KEY (shared with ipr-agreement.yml) to mint the App token so reviews count toward branch protection. Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ports the Argus AI PR reviewer from
adcontextprotocol/adcpto this repo. Two files:.github/workflows/ai-review.yml— the workflow (App-token mint, skip-on-trivial-resync,claude-code-action, posted-review verification, failure-comment fallback)..github/ai-review/expert-adcp-reviewer.md— the Argus prompt (voice + format unchanged; MUST FIX / coverage / triage adapted for this repo).Uses
IPR_APP_ID/IPR_APP_PRIVATE_KEY(shared withipr-agreement.yml) plusANTHROPIC_API_KEYto post reviews as the IPR bot, so they count toward branch protection.Key adaptations vs upstream
.changeset/*,mintlify-docs/*,static/schemas/cache/*,*.test.ts,package-lock.jsondocs/*,examples/*,tests/*,test_*.py,*_test.py,src/adcp/types/generated_poc/*,src/adcp/types/_generated.py,CHANGELOG.md,schemas/*,llms.txtstatic/schemas/source/**majorchangeset!/BREAKING CHANGE:(release-please semver signal)oneOfwalker regressionUnknownFormatAsset-style fallback, narrowsadditionalProperties, removes discriminator value)stable/aliases/_ergonomicmodules importing fromgenerated_poc/or_generated.py, per CLAUDE.md# type: ignore, suppressedruffrulesrc/adcp/types/**(non-gen),protocols/**,decisioning/**,migrate/**, mypy plugin →python-expertVoice, sign-off ladder, decision tree, largest-file rule, test-plan-honesty rule, and the verify-posted / failure-comment steps are unchanged.
Test plan
.github/workflows/) —@bokelleyapproval required.AI PR Review (Argus)and Argus posts a review as the IPR bot.Check for skippable re-runstep and skips.⚠️ Argus review could not completecomment on the PR.🤖 Generated with Claude Code