AC2 - Larissa Ault - #22
Open
ctlaultdel wants to merge 11 commits into
Open
Conversation
…pdating alphabet object when letters drawn
ilana-adadev
reviewed
Feb 1, 2023
| }; | ||
| } | ||
|
|
||
| decreaseLetterCount(letter) { |
ilana-adadev
reviewed
Feb 1, 2023
| @@ -1,15 +1,71 @@ | |||
| import { Alphabet } from "./modules/Alphabet.js"; | |||
There was a problem hiding this comment.
Way to go, breaking your code in to separate files!
ilana-adadev
reviewed
Feb 1, 2023
| // collect index of letter | ||
| const index = handArr.indexOf(letter); | ||
| // remove letter from copy of letters in hand - prevent duplication | ||
| handArr.splice(index, 1); |
There was a problem hiding this comment.
nice use of splice for the removal
ilana-adadev
reviewed
Feb 1, 2023
| export const usesAvailableLetters = (input, lettersInHand) => { | ||
| // Implement this method for wave 2 | ||
| // convert input string to array | ||
| const inputArr = [...input.toUpperCase()]; |
There was a problem hiding this comment.
cue gwen stefanni!
(nice use of spread syntax :) )
ilana-adadev
reviewed
Feb 1, 2023
| @@ -0,0 +1,47 @@ | |||
| export class Alphabet { | |||
ilana-adadev
reviewed
Feb 1, 2023
| @@ -0,0 +1,16 @@ | |||
| import { Alphabet } from "./Alphabet"; | |||
|
|
|||
| export class Hand extends Alphabet { | |||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.