Add integration test for localStorage preference helper persisting sort order across re-renders#518
Closed
wheval wants to merge 1 commit into
Closed
Conversation
…ross re-renders - Saved 'desc' sort preference is read back correctly after simulated remount - Default 'asc' sort applied when no preference is stored in localStorage - Overwriting a preference reflects the new value on next read - Clearing storage resets to the default sort order - Sort key is isolated from unrelated localStorage entries Closes accesslayerorg#478
|
👋 Hey @wheval, thanks for your contribution! This PR is targeting Please close this PR and reopen it with Closing this PR automatically. See you in |
✅ Deploy Preview for accesslayer ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds an integration test suite for
setPreference/getPreferenceverifying that sort order preferences survive a simulated unmount/remount cycle.Changes
src/utils/__tests__/preferences.sort.integration.test.ts— new integration testsdescsort is read back after remountascapplied when no preference storedCloses #478