Add response body matchers#37
Open
Piiit wants to merge 4 commits into
Open
Conversation
mmalfertheiner
requested changes
Jul 15, 2026
| return this; | ||
| } | ||
|
|
||
| public ResponseBodyMatchers ignoringAudition() { |
Member
There was a problem hiding this comment.
ignoringAudition()/ignoreAudition look like a typo — the fields being excluded (createdAt, createdBy, updatedAt, updatedBy) are audit fields, not "audition" fields. Worth renaming to ignoringAuditFields()/ignoreAuditFields.
| try { | ||
| var json = mvcResult.getResponse().getContentAsString(); | ||
| var extractedValue = JsonPath.read(json, jsonPath); | ||
| T actualObject = JSON_MAPPER.readValue(JSON_MAPPER.writeValueAsString(extractedValue), targetClass); |
Member
There was a problem hiding this comment.
According to AI you could use JSON_MAPPER.convertValue(extractedValue, targetClass) instead of serializing to a string and re-parsing — same result, avoids a redundant JSON round-trip. Can you check that proposal?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I know that we return the response object and test against that directly with normal assert methods in newer projects, but in older ones we use this body matcher instead. I found a bug in EMVA and instead of fixing it also in Aichner, it would be better to move it to the lib and deprecate both copy/paste implementations in each project