fix(ci): unbreak docs deploy and catalog lint#543
Merged
Conversation
…idation Two failures surfaced on main after PR #542 (schema checkpoint consolidation): - Deploy Documentation: the workflow ran `npm run docs:cli` without building the CLI first, so `cli/dist/cli/commands.js` did not exist. Build the CLI before the doc generators. - Docs Catalog Lint: doclint's retired-range guard (ADR-900 vacated 1–99) flagged old ADR references carried verbatim into the generated schema reference from `COMMENT ON` text in the baseline DDL. The `.sql` source is already outside the guard's scan, so exempt the generated `docs/reference/` tree too — the refs belong to the source, not the derived page. Claude-Session: https://claude.ai/code/session_017Her5fGimBvtzYD4q9tNnf
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Two CI jobs went red on
mainafter #542 (schema checkpoint consolidation). This is the fast fix to get a clean pass before landing the follow-up docs work.Changes
npm run docs:cliwithout building the CLI, socli/dist/cli/commands.jswas missing. Now builds the CLI first.COMMENT ONtext in the baseline DDL..sqlis already outside the guard's scan, so the generateddocs/reference/tree is now exempted too — those refs belong to the source, not the derived page.Verification (local)
doclint.py --check --enforce-adrs→ exit 0 (was 40 errors)npm run build && docs:cli && docs:mcp) → all OKhttps://claude.ai/code/session_017Her5fGimBvtzYD4q9tNnf