feat: unify group elevation into root command - #22
Merged
Conversation
Merge group membership elevation into the root command instead of a separate `grant groups` subcommand. The interactive selector now shows both cloud roles and Entra ID groups in a single unified list. - Add --groups flag to filter interactive selector to groups only - Add --group/-g flag for direct group elevation - Replace targetSelector + groupSelector with unifiedSelector in favorites add, showing both cloud and group items - Remove grant groups subcommand (absorbed into root) - Remove groupSelector interface and related dead code - Add selectionItem tagged union and unified selection helpers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
grant groupssubcommand removedgrant favorites addinteractive mode also shows the unified list, saving group selections as groups-type favorites--groupsflag (filter to groups only) and--group/-gflag (direct group elevation)groupSelectorinterface and dead code in favor ofunifiedSelectorTest plan
make test— all unit tests pass (16 files changed, new tests for unified selection in root + favorites)make lint— clean