Skip to content

refactor: apply factory pattern to status command #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aaearon merged 1 commit into from
Feb 19, 2026
Merged

refactor: apply factory pattern to status command #16

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 18 additions & 22 deletions cmd/status.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,41 +12,37 @@ import (
"github.com/spf13/cobra"
)

// NewStatusCommand creates the status command
func NewStatusCommand() *cobra.Command {
// newStatusCommand creates the status cobra command with the given RunE function.
func newStatusCommand(runFn func(*cobra.Command, []string) error) *cobra.Command {
cmd := &cobra.Command{
Use: "status",
Short: "Show authentication state and active SCA sessions",
Long: "Display the current authentication state and list all active elevated sessions.",
RunE: func(cmd *cobra.Command, args []string) error {
ispAuth, svc, profile, err := bootstrapSCAService()
if err != nil {
return err
}

return runStatus(cmd, ispAuth, svc, svc, profile)
},
RunE: runFn,
}

cmd.Flags().StringP("provider", "p", "", "filter sessions by provider (azure, aws)")

return cmd
}

// NewStatusCommandWithDeps creates a status command with injected dependencies for testing
func NewStatusCommandWithDeps(authLoader authLoader, sessionLister sessionLister, eligLister eligibilityLister) *cobra.Command {
cmd := &cobra.Command{
Use: "status",
Short: "Show authentication state and active SCA sessions",
Long: "Display the current authentication state and list all active elevated sessions.",
RunE: func(cmd *cobra.Command, args []string) error {
return runStatus(cmd, authLoader, sessionLister, eligLister, nil)
},
}
// NewStatusCommand creates the production status command.
func NewStatusCommand() *cobra.Command {
return newStatusCommand(func(cmd *cobra.Command, args []string) error {
ispAuth, svc, profile, err := bootstrapSCAService()
if err != nil {
return err
}

cmd.Flags().StringP("provider", "p", "", "filter sessions by provider (azure, aws)")
return runStatus(cmd, ispAuth, svc, svc, profile)
})
}

return cmd
// NewStatusCommandWithDeps creates a status command with injected dependencies for testing.
func NewStatusCommandWithDeps(authLoader authLoader, sessionLister sessionLister, eligLister eligibilityLister) *cobra.Command {
return newStatusCommand(func(cmd *cobra.Command, args []string) error {
return runStatus(cmd, authLoader, sessionLister, eligLister, nil)
})
}

func runStatus(cmd *cobra.Command, authLoader authLoader, sessionLister sessionLister, eligLister eligibilityLister, profile *models.IdsecProfile) error {
Expand Down