Skip to content

fix: correct decorator order in prompt-service so auth_required is enforced #1964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alpakalee wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: correct decorator order in prompt-service so auth_required is enforced #1964

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion prompt-service/src/unstract/prompt_service/controllers/answer_prompt.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,8 @@
answer_prompt_bp = Blueprint("answer-prompt", __name__)


@AuthHelper.auth_required
@answer_prompt_bp.route("/answer-prompt", methods=["POST"])
@AuthHelper.auth_required
def prompt_processor() -> Any:
platform_key = AuthHelper.get_token_from_auth_header(request)
payload: dict[Any, Any] = request.json
Expand Down
2 changes: 1 addition & 1 deletion prompt-service/src/unstract/prompt_service/controllers/extraction.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,8 @@
]


@AuthHelper.auth_required
@extraction_bp.route("/extract", methods=["POST"])
@AuthHelper.auth_required
def extract() -> Any:
Comment on lines 21 to 23
Copy link
Copy Markdown
Contributor

@greptile-apps greptile-apps Bot May 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Missing functools.wraps in auth_required changes Flask endpoint names

Now that @route is applied after @AuthHelper.auth_required, Flask registers the inner wrapper function (returned by auth_required) rather than the original handler. Because auth.py's auth_required does not call @functools.wraps(func) on its wrapper, the three endpoints are now registered under the endpoint name "wrapper" instead of "extract", "index", and "prompt_processor". Each lives in a separate blueprint so there is no immediate collision here, but if a second @auth_required-decorated route is ever added to any of these blueprints the app will crash at startup with a duplicate-endpoint AssertionError. Adding @functools.wraps(func) to the wrapper inside AuthHelper.auth_required in helpers/auth.py fixes this for all three controllers at once.

Prompt To Fix With AI 
This is a comment left during a code review.
Path: prompt-service/src/unstract/prompt_service/controllers/extraction.py
Line: 21-23

Comment:
**Missing `functools.wraps` in `auth_required` changes Flask endpoint names**

Now that `@route` is applied after `@AuthHelper.auth_required`, Flask registers the inner `wrapper` function (returned by `auth_required`) rather than the original handler. Because `auth.py`'s `auth_required` does not call `@functools.wraps(func)` on its wrapper, the three endpoints are now registered under the endpoint name `"wrapper"` instead of `"extract"`, `"index"`, and `"prompt_processor"`. Each lives in a separate blueprint so there is no immediate collision here, but if a second `@auth_required`-decorated route is ever added to any of these blueprints the app will crash at startup with a duplicate-endpoint `AssertionError`. Adding `@functools.wraps(func)` to the `wrapper` inside `AuthHelper.auth_required` in `helpers/auth.py` fixes this for all three controllers at once.

How can I resolve this? If you propose a fix, please make it concise.

Fix in Claude Code

platform_key = AuthHelper.get_token_from_auth_header(request)
payload: dict[Any, Any] = request.json
Expand Down
2 changes: 1 addition & 1 deletion prompt-service/src/unstract/prompt_service/controllers/indexing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,8 @@
]


@AuthHelper.auth_required
@indexing_bp.route("/index", methods=["POST"])
@AuthHelper.auth_required
def index() -> Any:
"""Endpoint for indexing documents into the vector database.

Expand Down