test: add unit tests for lowest-coverage packages#91
Open
devin-ai-integration[bot] wants to merge 1 commit into
Open
test: add unit tests for lowest-coverage packages#91devin-ai-integration[bot] wants to merge 1 commit into
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
Add unit tests for four packages that previously had 0% coverage: - internal/modelref (Parse) -> 100% - internal/service/server/session (InMemoryManager) -> ~95% - internal/service/server/trace (FileWriter) -> 100% - internal/service/server/usage (StatsTracker) -> 100% Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
go test -cover ./...surfaced four packages with 0% coverage (no test files at all). This PR adds table-driven unit tests for the three lowest-coverage/untested logic packages plus the puremodelrefparser, without touching any production code.internal/modelrefinternal/service/server/traceinternal/service/server/usageinternal/service/server/sessionWhat the new tests cover:
modelref.Parse— bothprovider/modelandmodel(provider)forms, whitespace trimming, precedence of the paren form, and fallbacks (empty provider/model inside parens,(x)at index 0, missing), multi-slash, empty string).session.InMemoryManager—GetOrCreatecreate-vs-reuse, TTL pruning (both explicitPruneand prune-on-lookup), LRU eviction underMaxSessionsincluding recency update on reuse,Listsnapshot,NewEphemeralnot being tracked, and the plugin-registryExtensionDatainit/backfill branches. Remaining uncovered lines are the hourlystartPruningticker.trace.FileWriter—WriteTracecategory dispatch (Chat / Response / Anthropic, individually and combined) verified by inspecting files written to a temp dir, no-category / disabled-tracer / nil-tracer no-ops, and theWriteCategoryerror-reporting branch (forced via an unwritable root).usage.StatsTracker—RecordBillingaccounting + cost,CostForRequestcomputation (no side effects), unknown-model and nil-stats guards.Tests use dependency injection via small fakes (
fakeConfigimplementingConfigAccessor) and real collaborators (plugin.NewRegistry(nil),stats.NewSessionStats,mbtrace.New(...)witht.TempDir()), mirroring the existing test style in the repo.go test ./...andgo vetpass;gofmtclean.Link to Devin session: https://app.devin.ai/sessions/2db8a2c166aa495e984b9fbcb97fe9bf
Requested by: @ZhiYi-R