Skip to content

network/services/ead: fix t_fromhex whitespace and non-hex parsing#183

Merged
manupawickramasinghe merged 1 commit into
mainfrom
ead-t-fromhex-fix-11444315272486179334
Jun 21, 2026
Merged

network/services/ead: fix t_fromhex whitespace and non-hex parsing#183
manupawickramasinghe merged 1 commit into
mainfrom
ead-t-fromhex-fix-11444315272486179334

Conversation

@ManupaKDU

Copy link
Copy Markdown

Update t_fromhex to correctly ignore whitespace and non-hex digits during conversion, fulfilling the FIXME comment.

The parser counts valid hex characters using isxdigit from <ctype.h> to compute the size accurately. When extracting values, it consumes input by bypassing any invalid characters.

Signed-off-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>


PR created automatically by Jules for task 11444315272486179334 started by @manupawickramasinghe

Update t_fromhex in tinysrp to correctly count and consume only valid hexadecimal digits, skipping any whitespace or non-hex characters as intended.

Signed-off-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>

Co-authored-by: manupawickramasinghe <[email protected]>
@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@manupawickramasinghe manupawickramasinghe merged commit 6e6a1af into main Jun 21, 2026
7 of 11 checks passed
@manupawickramasinghe manupawickramasinghe deleted the ead-t-fromhex-fix-11444315272486179334 branch June 21, 2026 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants