🧪 Add unit tests for isValidTimeRange#95
Conversation
Adds comprehensive unit tests for `isValidTimeRange` in `dateUtil.ts` to cover 12-hour and 24-hour formats, edge cases (whitespace), and error conditions (missing leading zeros, logically invalid intervals, etc). Also fixes a syntax error in the adjacent `formatTimeAgo.test.ts`. Co-authored-by: manupawickramasinghe <[email protected]>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
PR template validation noticeThe PR description could not be validated against the pull request template. Items to review:
Please consider updating your PR description to include all required sections from the template. |
Renames the local `client` variable in `GenAIClientManager._get_client` to `new_client` to avoid shadowing the loop-scope or outer-scope `client` that was caught by mypy's `[no-redef]` rule in `frigate/genai/manager.py`. Co-authored-by: manupawickramasinghe <[email protected]>
1 participant
🎯 What: Adds unit tests to cover the previously untested
isValidTimeRangefunction inweb/src/utils/dateUtil.ts. It verifies that the function correctly parses 12-hour and 24-hour formats and handles invalid date inputs appropriately.📊 Coverage: Covered missing commas or incorrect item counts, 24-hour valid and invalid scenarios (including logically impossible times like start > end), 12-hour valid and invalid scenarios (including AM/PM validations), and missing leading zeros.
✨ Result: Increased testing coverage and robustness for the
dateUtil.tsutility functions. Also fixed an existing syntax error inweb/src/lib/__tests__/formatTimeAgo.test.tsto unblock the test runner.PR created automatically by Jules for task 4520268449157004046 started by @manupawickramasinghe