Fix failing tests and document improvements#106
Conversation
- Added `.zektopic/status.md` indicating current test status. - Added `Jules/improvements.md` highlighting technical debt and future refactoring tasks. - Fixed a `NoneType` attribute error in `frigate/api/media.py` by properly checking if the frame is `None`. - Fixed a timestamp conversion issue in `frigate/api/review.py` by using appropriate index conversion logic for the current Pandas version. - Corrected a preset name in `frigate/test/test_ffmpeg_presets.py` causing an assertion error. Co-authored-by: ManupaKDU <[email protected]>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
PR template validation noticeThe PR description could not be validated against the pull request template. Items to review:
Please consider updating your PR description to include all required sections from the template. |
- Added `.zektopic/status.md` indicating current test status. - Added `Jules/improvements.md` highlighting technical debt and future refactoring tasks. - Fixed a `NoneType` attribute error in `frigate/api/media.py` by properly checking if the frame is `None`. - Fixed a timestamp conversion issue in `frigate/api/review.py` by using appropriate index conversion logic for the current Pandas version. - Corrected a preset name in `frigate/test/test_ffmpeg_presets.py` causing an assertion error. Co-authored-by: ManupaKDU <[email protected]>
- Added `.zektopic/status.md` indicating current test status. - Added `Jules/improvements.md` highlighting technical debt and future refactoring tasks. - Fixed a `NoneType` attribute error in `frigate/api/media.py` by properly checking if the frame is `None`. - Fixed a timestamp conversion issue in `frigate/api/review.py` by using appropriate index conversion logic for the current Pandas version. - Corrected a preset name in `frigate/test/test_ffmpeg_presets.py` causing an assertion error, and ensure format resolution logic in `parse_preset_hardware_acceleration_encode` processes `preset-vaapi`. Co-authored-by: ManupaKDU <[email protected]>
1 participant
Fix failing tests and document improvements
.zektopic/status.mdindicating current test status.Jules/improvements.mdhighlighting technical debt and future refactoring tasks.NoneTypeattribute error infrigate/api/media.pyby properly checking if the frame isNone.frigate/api/review.pyby using appropriate index conversion logic for the current Pandas version.frigate/test/test_ffmpeg_presets.pycausing an assertion error.PR created automatically by Jules for task 10842190485999999381 started by @ManupaKDU