Module : Chart Intchart.com - Show chart in modal

[VD17593]

The proposal is to include a functionality to the client side for the users of the new app : Chart Intchart.com.

This app allows to monitor devices and log to a chart.
It will add a little icon to the logged device.
Once the icon clicked, the chart will open in a modal screen.

To have this chart available on the smarthome 3 additions are needed.

Since I'm not familiar with the way this build.js file is created (from the previous included additions), to be sure I included the final result in a new build.js.

This is the file I used to test the module, and normally everything should run as expected.

[ronie-z-wave]

Hi,
unfortunately by concentrating on next major release v2.3.0 it was not yet possible for us to check your pull request (nice feature 👍 ) against our current changes ...
After v2.3.0 is out we'll plan to put it into next minor release

Thx for your support!

[VD17593]

Hi, I was wondering if the feature had already been included, since I would like to have a look at the result. And to build further on that, I was thinking of including some additional possibilities, since now the charting starts to be heavily used. Regards Vincent Van: ronie-z-wave [mailto:[email protected]] Verzonden: vrijdag 27 januari 2017 11:28 Aan: Z-Wave-Me/zwave-smarthome <[email protected]> CC: VD17593 <[email protected]>; Author <[email protected]> Onderwerp: Re: [Z-Wave-Me/zwave-smarthome] Module : Chart Intchart.com - Show chart in modal (#205) Hi, unfortunately by concentrating on next major release v2.3.0 it was not yet possible for us to check your pull request (nice feature 👍 ) against our current changes ... After v2.3.0 is out we'll plan to put it into next minor release Thx for your support! — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#205 (comment)> , or mute the thread <https://github.com/notifications/unsubscribe-auth/AFm05Gxefgq6wDZDIWhLxiVFV9w-C4D0ks5rWcamgaJpZM4LPQ9J> . <https://github.com/notifications/beacon/AFm05GfRly1gUHMUpDc0z-57B8l6-21rks5rWcamgaJpZM4LPQ9J.gif>

[ronie-z-wave]

Hi Vincent,

At first: Sorry for this long waiting period.

Please checkout : 455cacd

Because of the conflicts I've felt free to add you feature manually - also to have it in new test builds.

Charts with only one device in it look ok, but it looks a bit strange if I check 'show all together' in your app. Seems that combined chart is still on 0 ...

Also moving the curser/fade cross will produce some errors in browsers console, not sure if this is caused by ui's jquery version.

BR ronie

PS: Please try to do pull request on the dev branch in future. ;)

[VD17593]

Hi Ronie, Nice to have it included. Tanks a lot. Normally also the combined charts should be fine (like in enclosed example). What do you mean on 0 (Maybe the scales are not correspondent.) And also moving the cursor to indicate the values should work fine (see example). I’ve tested it on chrome. When I checked your inclusion with my version I saw a difference in “app/views/elements/list.html” and in “dist/app/js/build.js” : You have : class=\"widget-icon widget-chart\" My verson : class=\"widget-icon widget-history\" Maybe this could be the reason? Since it’s a while I’m not certain what the impact is of this change. Regards, Vincent Van: ronie-z-wave [mailto:[email protected]] Verzonden: woensdag 15 maart 2017 15:17 Aan: Z-Wave-Me/zwave-smarthome <[email protected]> CC: VD17593 <[email protected]>; Author <[email protected]> Onderwerp: Re: [Z-Wave-Me/zwave-smarthome] Module : Chart Intchart.com - Show chart in modal (#205) Hi Vincent, At first: Sorry for this long waiting period. Please checkout : <455cacd> 455cacd Because of the conflicts I've felt free to add you feature manually - also to have it in new test builds. Charts with only one device in it look ok, but it looks a bit strange if I check 'show all together' in your app. Seems that combined chart is still on 0 ... Also moving the curser/fade cross will produce some errors in browsers console, not sure if this is caused by ui's jquery version. BR ronie — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#205 (comment)> , or mute the thread <https://github.com/notifications/unsubscribe-auth/AFm05G2OGaT0sR0f2bZlUf-yM1xECer6ks5rl_L5gaJpZM4LPQ9J> . <https://github.com/notifications/beacon/AFm05HNx9LuzbNyLxXQQXNIpIJ6qp8klks5rl_L5gaJpZM4LPQ9J.gif>

[ronie-z-wave]

Hi Vincent,

You have : class="widget-icon widget-chart"
My verson : class="widget-icon widget-history"

That's true I want to differentiate abit from history widget ;)

But I've testet it again, no problems, looks good. So maybe the cause was lack of data.

Cheers

[VD17593]

Hi Ronie, Nice. You said you’re planning this for some next release. If you could notify when this is live, I could reinstall everything to have a look if it’s ok. One of the things I’m thinking of adding is to have the chart on the application look the same as on intchart.com. So the users could change settings in intchart.com and have the same chart on the app. If you think of something that could be useful, don’t hesitate. Regards, Vincent Van: ronie-z-wave [mailto:[email protected]] Verzonden: donderdag 16 maart 2017 07:20 Aan: Z-Wave-Me/zwave-smarthome <[email protected]> CC: VD17593 <[email protected]>; Author <[email protected]> Onderwerp: Re: [Z-Wave-Me/zwave-smarthome] Module : Chart Intchart.com - Show chart in modal (#205) Hi Vincent, You have : class="widget-icon widget-chart" My verson : class="widget-icon widget-history" That's true I want to differentiate abit from history widget ;) But I've testet it again, no problems, looks good. So maybe the cause was lack of data. Cheers — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#205 (comment)> , or mute the thread <https://github.com/notifications/unsubscribe-auth/AFm05DGfdylh8WSo5CU8a2xTrMgH_igdks5rmNSjgaJpZM4LPQ9J> . <https://github.com/notifications/beacon/AFm05A2uItvZQGOJJMzfQuTE2nM5VNKaks5rmNSjgaJpZM4LPQ9J.gif>