First run of a new job is never persisted to dynamodb#1109
Draft
CharlesPeacock wants to merge 1 commit into
Draft
First run of a new job is never persisted to dynamodb#1109CharlesPeacock wants to merge 1 commit into
CharlesPeacock wants to merge 1 commit into
Conversation
CharlesPeacock
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to fix a bug where Tron did not to attach a watcher to the first run of a new job. Interestingly enough, this bug has existed for several years now; since 85% of Tron jobs run every 20 minutes or so, this went unnoticed for a while since reaching the run_limit for a given job removes the old runs from the tail.
This will help heavier, less frequent job runs in ensuring data integrity and consistent observability across Tron. A unit test has been added to assert old behavior is no longer present.
All tests pass, keeping as draft PR for the time being until I verify more job runs on my local env.