Skip to content

Remove package.json#1102

Merged
KaspariK merged 3 commits into
masterfrom
kedarv-patch-1
Jul 21, 2026
Merged

Remove package.json#1102
KaspariK merged 3 commits into
masterfrom
kedarv-patch-1

Conversation

@kedarv

@kedarv kedarv commented Jun 17, 2026

Copy link
Copy Markdown
Member

v10 is rather ancient, let's pin the the oldest available LTS instead

@kedarv
kedarv requested a review from a team as a code owner June 17, 2026 18:29
@nemacysts

Copy link
Copy Markdown
Member

@kedarv any context behind this change/have you been able to test this locally?

@kedarv

kedarv commented Jun 17, 2026

Copy link
Copy Markdown
Member Author

@kedarv any context behind this change/have you been able to test this locally?

Added context in the summary, but just pinning the minimum version to a supported node LTS version. I'm actually not sure why this repo needs a package.json file to begin with, so not sure how to test it 😅

@nemacysts

Copy link
Copy Markdown
Member

@kedarv any context behind this change/have you been able to test this locally?

Added context in the summary, but just pinning the minimum version to a supported node LTS version. I'm actually not sure why this repo needs a package.json file to begin with, so not sure how to test it 😅

ah gotcha, we have a funky Coffeescript-based UI - i was gonna say that this was required for that...but after some git history spelunking: i think this is dead code leftover from when we had some eslint hooks for a React-based UI re-write

...or in other words: i think we can probably just delete this lol

@KaspariK

KaspariK commented Jun 17, 2026

Copy link
Copy Markdown
Member

@kedarv any context behind this change/have you been able to test this locally?

Added context in the summary, but just pinning the minimum version to a supported node LTS version. I'm actually not sure why this repo needs a package.json file to begin with, so not sure how to test it 😅

Yeah @nemacysts and I are chatting and we think this is likely a relic of a React TronWeb.

At any rate, it's not relevant to how we build Tron today (seems we use node 12.22 in the build though :p)

*edit: Node 12.22 is in the Jammy image and used by the distro coffeescript toolchain

@kedarv

kedarv commented Jun 17, 2026

Copy link
Copy Markdown
Member Author

@nemacysts @KaspariK sounds good, deleted the file instead.

@kedarv
kedarv requested a review from nemacysts June 17, 2026 23:08
@KaspariK KaspariK changed the title Update package.json nodejs Remove package.json Jul 20, 2026
@KaspariK
KaspariK merged commit b590d73 into master Jul 21, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants