Add advisory perlcritic config and CI#91
Open
tomjn wants to merge 1 commit into
Open
Conversation
Adds a lenient .perlcriticrc (severity 5 only, to start) and a GitHub Actions job that runs perlcritic over src/. The job is marked continue-on-error so it is advisory and never fails the build, since this codebase has not previously been linted; the severity threshold and the non-blocking flag can be tightened over time as findings are triaged. perlcritic was not available in my environment, so the CI step itself is unverified locally; the config and workflow are standard.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
.perlcriticrc: a deliberately lenient starting policy (severity 5 only)..github/workflows/perlcritic.yml: a GitHub Actions job that runsperlcriticover
src/, markedcontinue-on-errorso it is advisory and never fails thebuild.
Why
Adds a static-analysis signal without imposing a wall of findings on a codebase
that has not previously been linted. perlcritic uses PPI (static parsing) so it
needs none of the runtime/sibling dependencies. The intent is to start gentle and
tighten the severity threshold (and drop
continue-on-error) over time asfindings are triaged.
Honest caveat
perlcriticwas not available in my environment, so I could not run it againstthe tree locally — the config and workflow are standard but the actual findings
(and the exact severity that produces a useful, non-noisy result) should be
confirmed from the first CI run. Starting advisory means a surprising result
can't break anything.