Fix: OptimizedSpatialIndex quadtree slower than DefaultSpatialIndex#19
Merged
Conversation
…lower than DefaultSpatialIndex - Implement circle-AABB intersection (intersectsRange) for spatial pruning in _query - Replace inBounds check with intersectsRange so queries with center outside node still work - Optimize update() to skip remove+insert when object stays in same leaf node - Change spatialObjects from shared_ptr to value storage for cache-friendly access - Remove leftover debug printf in clear() - Re-enable QueryFarAwayButWithinRangeReturnsResults test that previously failed - Add benchmark test suite comparing Default vs Optimized spatial index Before: Optimized was 0.44x Default (slower). After: 7.68x faster than Default. Co-Authored-By: Claude Opus 4.6 <[email protected]>
The Build step had `if: github.event_name == 'push'` which skipped compilation on PRs, causing ctest to fail with missing executables. Co-Authored-By: Claude Opus 4.6 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
OptimizedSpatialIndexslower thanDefaultSpatialIndex(linear scan)_queryinBoundsrejecting valid queries where center is outside node but range overlapsupdate()to skip remove+insert when object stays in same leafshared_ptr<SpatialObject<T>>with value storage for cache-friendly accessprintfinclear()Benchmark Results
Before (buggy)
After (fixed)
Test plan
QueryFarAwayButWithinRangeReturnsResults)🤖 Generated with Claude Code