Remove explicit /Zi and /DEBUG, use CMAKE_MSVC_DEBUG_INFORMATION_FORMAT#316
Open
shbhamid-amd wants to merge 1 commit into
Open
Remove explicit /Zi and /DEBUG, use CMAKE_MSVC_DEBUG_INFORMATION_FORMAT#316shbhamid-amd wants to merge 1 commit into
shbhamid-amd wants to merge 1 commit into
Conversation
Remove unconditional /Zi compiler flag and /DEBUG linker flag that forced PDB generation across all build configurations including Release. Replace with CMAKE_MSVC_DEBUG_INFORMATION_FORMAT using a generator expression so PDBs are only generated for Debug and RelWithDebInfo. This reduces binary size and build time for Release builds. Signed-off-by: Shiva Shanker Bhamidipati <[email protected]>
xingy16-amd
approved these changes
Jul 7, 2026
Member
|
@xingy16-amd, how much binary size reduction are we talking about? I would imagine all debug information is going into a separate PDB file. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/Zicompiler flag fromadd_compile_optionsincmake/windows.cmake/DEBUGlinker flag fromadd_link_optionsCMAKE_MSVC_DEBUG_INFORMATION_FORMATset toProgramDatabaseonly for Debug and RelWithDebInfo configurationsWhy
The current setup forces PDB generation (
/Zi) and debug linking (/DEBUG) unconditionally across all build configurations including Release. This increases binary size and build time for release builds unnecessarily.By using
CMAKE_MSVC_DEBUG_INFORMATION_FORMATwith a generator expression, PDBs are only generated for Debug and RelWithDebInfo where they are actually needed.This upstreams the xmc monorepo patch (
aiebu_no_explicit_Zi.patch).Changes
cmake/windows.cmake: Removed/Zifrom compile options, removed/DEBUGfrom link options, addedCMAKE_MSVC_DEBUG_INFORMATION_FORMATwith config-conditional generator expressionTest plan
aiebu_no_explicit_Zi.patchfrom xmcpatches/andbin/xmc/vcs/patch.shSigned-off-by: Shiva Shanker Bhamidipati [email protected]