Fixing the mysql socket commands.

[micheas]

This is because the default socket was being used.

[gemini-code-assist]

Summary of Changes

Hello @micheas, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines the MySQL connection mechanism within the load_sqldump utility. The primary goal is to enhance connection flexibility by prioritizing Unix socket connections when configured, while maintaining robust TCP/IP connectivity as a default. This change also standardizes the way MySQL passwords are provided to the command-line tool, ensuring consistency and potentially resolving issues related to default socket usage.

Highlights

• MySQL Connection Logic: The load_sqldump function now conditionally uses Unix socket connections for MySQL if a unix_socket configuration is provided, falling back to TCP/IP connections otherwise. This allows for more flexible and potentially more efficient database connections.
• Password Handling Update: The method for passing the MySQL password has been updated. Instead of using the MYSQL_PWD environment variable, the password is now passed directly as a command-line argument using the -p flag for both Unix socket and TCP/IP connection types.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request adds support for connecting to MySQL via a Unix socket, which is a good improvement. However, it also changes how the database password is provided to the mysql command, introducing a security vulnerability by passing it as a command-line argument. My review includes a suggestion to revert to using the MYSQL_PWD environment variable, which is more secure, while keeping the new socket connection logic.

[micheas]

/gemini review

[gemini-code-assist]

Code Review

This pull request correctly adds support for connecting to MySQL via a Unix socket, which is necessary for environments like Google Cloud Run. The implementation is sound. I've added one suggestion to refactor the command construction logic to be more concise and adhere to the DRY (Don't Repeat Yourself) principle, which will improve maintainability.