Skip to content

Allow enabling Finder Scope inside of pywwt#387

Open
Carifio24 wants to merge 10 commits into
WorldWideTelescope:masterfrom
Carifio24:finder-scope
Open

Allow enabling Finder Scope inside of pywwt#387
Carifio24 wants to merge 10 commits into
WorldWideTelescope:masterfrom
Carifio24:finder-scope

Conversation

@Carifio24

@Carifio24 Carifio24 commented Jul 18, 2025

Copy link
Copy Markdown
Member

Overview

With the Finder Scope now embedded in the research app in WorldWideTelescope/wwt-webgl-engine#324 (and subsequent PRs), this PR adds the ability to turn the Finder Scope on from inside pywwt.

The changes are as follows:

  • Add a finder_scope_active traitlet to the WWT widget that controls whether the scope is active or not. This passes a message to the research app to control the relevant setting there
  • Add a finder_scope_place property to the widget that gives the current value under the Finder Scope as a wwt_data_formats.place.Place. If there isn't one, this value is None
  • We allow setting a callback to be executed every time the selected Finder Scope Place changes. This method is chosen for consistency with what we do for source selection.

TODO: Need to add a test

Checklist

  • Changed code has some test coverage (or justify why not)
  • Changes in functionality documented (or justify why not)

@Carifio24 Carifio24 linked an issue Jul 21, 2025 that may be closed by this pull request
@Carifio24
Carifio24 marked this pull request as ready for review July 23, 2025 20:27
@Carifio24

Copy link
Copy Markdown
Member Author

Rebase for some CI updates.

@Carifio24 Carifio24 closed this Sep 4, 2025
@Carifio24 Carifio24 reopened this Sep 4, 2025
@Carifio24

Copy link
Copy Markdown
Member Author

Rebased to pick up CI updates

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Finder Scope ability to pywwt

1 participant