Allow enabling Finder Scope inside of pywwt#387
Open
Carifio24 wants to merge 10 commits into
Open
Conversation
Member
Author
|
Rebase for some CI updates. |
…r Scope on and off.
Member
Author
|
Rebased to pick up CI updates |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
With the Finder Scope now embedded in the research app in WorldWideTelescope/wwt-webgl-engine#324 (and subsequent PRs), this PR adds the ability to turn the Finder Scope on from inside
pywwt.The changes are as follows:
finder_scope_activetraitlet to the WWT widget that controls whether the scope is active or not. This passes a message to the research app to control the relevant setting therefinder_scope_placeproperty to the widget that gives the current value under the Finder Scope as awwt_data_formats.place.Place. If there isn't one, this value isNonePlacechanges. This method is chosen for consistency with what we do for source selection.TODO: Need to add a test
Checklist