Add command palette commands to navigate to options pages#514
Open
faisalahammad wants to merge 1 commit into
Open
Add command palette commands to navigate to options pages#514faisalahammad wants to merge 1 commit into
faisalahammad wants to merge 1 commit into
Conversation
) Register one Command Palette command per SCF options page so users can jump straight to a page by typing its name (Cmd/Ctrl+K). - Localize registered options pages (filtered by capability) for the admin command script. - Build one command per page, deduplicated against WP 6.9+ auto-registered menu commands via a shared helper. - Add E2E fixture plugin and tests covering registration and navigation.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #140
Summary
Each registered SCF options page now gets its own Command Palette command, so users can jump straight to a page by typing its name (Cmd/Ctrl+K) instead of clicking through the admin menu. The command is filtered by capability on the server, so users only see pages they can open.
Changes
includes/admin/admin-commands.php
Before:
After:
Why: Ships the page list to the admin command script. The capability check runs server-side, so inaccessible pages never reach JS.
assets/src/js/commands/admin-commands.js
Before:
After:
Why: Builds one command per page from the localized data. The dedup check is refactored into a shared helper so the new options page commands skip duplicates the same way
viewCommandsdoes on WP 6.9+.How to test
npm run wp-env start.acf_update_options_page('my-page', ['menu_title' => 'My Page', 'menu_slug' => 'my-page', 'capability' => 'edit_posts'])).Expected: a single command with a page icon appears, and selecting it navigates to
admin.php?page=my-page.Automated:
The new "Options page-specific commands" block asserts the command appears exactly once and navigates to the correct URL.
Testing already taken place
npm run buildclean (only pre-existing sass warnings).Use of AI Tools
Some drafting assistance from AI tooling (Claude). All code reviewed, tested, and adjusted by hand.
Screenshot