This repository was archived by the owner on Jan 29, 2026. It is now read-only.
LA-224 AI fitting - step 3 - CommonJS - #52
Open
Edwin-van-der-Klaauw wants to merge 2 commits into
Open
Conversation
…SM while CJS refers to CommonJS. The latter is correct.
…s found in the Errors.cjs module.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a refactoring step; No code changes.
Nevertheless, note that jsconfig.json has changed.
Make it explicit which modules are following the CommonJS standard (and not ESM).
For JS/IDJS modules it is fine to assume CommonJS. So no action taken.
But for MJS modules, Node ESM is assumed.
That may confuse VSCode, Node and other tooling.
And more over, it will confuse JS developers.