Skip to content

Minimap button via LibDBIcon#37

Open
latchee wants to merge 3 commits into
Wishmaster117:mainfrom
latchee:main
Open

Minimap button via LibDBIcon#37
latchee wants to merge 3 commits into
Wishmaster117:mainfrom
latchee:main

Conversation

@latchee

@latchee latchee commented May 21, 2026

Copy link
Copy Markdown

The MultiBotMinimap.lua file (in the UI folder) does not use LibDBIcon and LibDataBroker even though those libs are available.
I worked with Claude and changed the code to use those libs. This allows the addon to register with any databroker (fubar, bazooka, chocolate bar)..

@Wishmaster117

Wishmaster117 commented May 30, 2026

Copy link
Copy Markdown
Owner

Hi @latchee thanks for this PR, i'm a little busy in IRL right now, i'll take a look sone.
A lot of stuff doesn’t use the ACE3 libraries yet.
I was mid‑migration to ACE3 when the dumb idea to build a bridge popped into my head. :D

latchee added 2 commits May 31, 2026 07:42
The linter doesn't know MultiBotMinimapIconDB is a legitimate SavedVariable global. The fix is a single luacheck annotation at the top of the OnEvent block declaring it as an intentional global.
Added MultiBotMinimapIconDB to saved variables.
@latchee

latchee commented May 30, 2026

Copy link
Copy Markdown
Author

I am no expert but I ran those LUA lint warnings through Claude, we just needed to add the line 45 and the missing global saved variable MultiBotMinimapIconDB was also added to the toc file :

-- luacheck: globals MultiBotMinimapIconDB

The linter doesn't know MultiBotMinimapIconDB is a legitimate SavedVariable global. The fix is a single luacheck annotation at the top of the OnEvent block declaring it as an intentional global.Edited a file, read a fileEdited a file, read a file
The -- luacheck: globals MultiBotMinimapIconDB annotation tells the linter that this global is intentional — covering all six warnings at once (setting, accessing, and mutating it). This is the standard way to declare WoW SavedVariables in projects that run luacheck, since the linter has no way to infer them from the .toc file on its own.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants