Skip to content

Fix filtered unit refresh rebuilding everybars in large raids#29

Merged
Wishmaster117 merged 1 commit into
mainfrom
Fix-filtered-unit-refresh-rebuilding-everybars-in-large-raids
May 13, 2026
Merged

Fix filtered unit refresh rebuilding everybars in large raids#29
Wishmaster117 merged 1 commit into
mainfrom
Fix-filtered-unit-refresh-rebuilding-everybars-in-large-raids

Conversation

@Wishmaster117

Copy link
Copy Markdown
Owner

Summary

Fixes a UI lockup reported when using the class filter in a 40-bot raid and changing a Hunter combat buff.

  • Limit class-filtered unit state refreshes to the currently displayed bots instead of refreshing every bot in the raid.
  • Avoid rebuilding bridge everybars when the bot class, combat strategies, and non-combat strategies have not changed.
  • Add the same rebuild guard for the legacy Strategies: fallback path.

Fixes

Fixes #27

Testing

  • Ran git diff --check.
  • Manual test target: 40-bot raid -> PlayerBot Main Menu -> Class filter -> Hunter -> change a Hunter combat buff -> verify MultiBot buttons, Escape, Character, and Social remain responsive.

## Summary
Fixes a UI lockup reported when using the class filter in a 40-bot raid and changing a Hunter combat buff.

- Limit class-filtered unit state refreshes to the currently displayed bots instead of refreshing every bot in the raid.
- Avoid rebuilding bridge everybars when the bot class, combat strategies, and non-combat strategies have not changed.
- Add the same rebuild guard for the legacy `Strategies:` fallback path.

## Fixes
Fixes #27

## Testing
- Ran `git diff --check`.
- Manual test target: 40-bot raid -> PlayerBot Main Menu -> Class filter -> Hunter -> change a Hunter combat buff -> verify MultiBot buttons, Escape, Character, and Social remain responsive.
@Wishmaster117
Wishmaster117 merged commit 43aebcd into main May 13, 2026
2 of 4 checks passed
@Wishmaster117
Wishmaster117 deleted the Fix-filtered-unit-refresh-rebuilding-everybars-in-large-raids branch May 13, 2026 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Issue] Whole UI breaks when using Addon

1 participant