Skip to content

Suggested wording for a few labels #1537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
framawiki wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Suggested wording for a few labels #1537

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
cef4657
Rename "Search" filter label
framawiki Jul 1, 2026
30dde62
More specific translators documentation
framawiki Jul 1, 2026
99afee5
Clarify the wording of approval_notification email
framawiki Jul 1, 2026
f1b51b6
Clarify wording of access filter
framawiki Jul 1, 2026
994644c
Clarify where "collection search" filters on
framawiki Jul 1, 2026
874cbb7
Fix placeholder content
framawiki Jul 1, 2026
4a6f495
More compact wording for Search placeholder
framawiki Jul 1, 2026
82bb3eb
Suggestion for better wording for renewals text
framawiki Jul 1, 2026
9abea5e
Apply Samwalton wording suggestions
framawiki Jul 8, 2026
9d58f48
Another wording fix
framawiki Jul 8, 2026
c657211
Last Samwalton wording suggestion
framawiki Jul 8, 2026
80eefb0
Rollback a wording change according to phab ticket
framawiki Jul 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion TWLight/emails/templates/emails/approval_notification-body-html.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
<p>Dear {{ user }},</p>
<p>Thank you for applying for access to {{ partner }} resources through The Wikipedia Library. We are happy to inform you that your application has been approved.</p>
<p>{{ user_instructions }}</p>
<p>You can view the collections you're authorized to access at My Library: {{ link }}</p>
<p>You can view the collections you're authorized to access on your My Library page: {{ link }}</p>
<p>Cheers!</p>
<p>The Wikipedia Library</p>
{% endblocktranslate %}
Expand Down
2 changes: 1 addition & 1 deletion TWLight/emails/templates/emails/approval_notification-body-text.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@

{{ user_instructions }}

You can view the collections you're authorized to access at My Library: {{ link }}
You can view the collections you're authorized to access on your My Library page: {{ link }}

Cheers!

Expand Down
6 changes: 3 additions & 3 deletions TWLight/resources/filters.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,9 @@
MULTI_STEP = 1
ACCESS_CHOICES = (
# Translators: On the MyLibrary page (https://wikipedialibrary.wmflabs.org/users/my_library), this indicates that a collection may be accessed immediately.
(INSTANT, _("Instant (proxy) access")),
(INSTANT, _("Instant access via the proxy")),
# Translators: On the MyLibrary page (https://wikipedialibrary.wmflabs.org/users/my_library), this indicates that a collection may be accessed only after additional steps, such as submitting an application and awaiting approval.
(MULTI_STEP, _("Multi-step access")),
(MULTI_STEP, _("Application required")),
)


Expand Down Expand Up @@ -74,7 +74,7 @@ class PartnerFilter(MainPartnerFilter):
"""

searchable = django_filters.MultipleChoiceFilter(
# Translators: On the MyLibrary page (https://wikipedialibrary.wmflabs.org/users/my_library), this text is shown to indicate if a collection is searchable.
# Translators: On the MyLibrary page (https://wikipedialibrary.wmflabs.org/users/my_library), this text is shown to indicate if a collection is searchable in the "global search bar" present in the top of the Library website. It indexes some of the partners content to list all results from the different partners in one page.
label=_("Searchable"),
choices=Partner.SEARCHABLE_CHOICES,
widget=forms.CheckboxSelectMultiple,
Expand Down
2 changes: 1 addition & 1 deletion TWLight/resources/templates/resources/filter_section.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,6 @@
<div class="dropdown-divider"></div>
{% comment %}Translators: On the Browse Partners page (https://wikipedialibrary.wmflabs.org/partners/), this is a placeholder for an input that helps users filter collections. {% endcomment %}
<input id="collection-live-search" class="form-control form-control-sm mr-sm-2"
type="search" placeholder="{% trans 'Filter collections' %}" aria-label="Filter">
type="search" placeholder="{% trans 'Search collection descriptions' %}" aria-label="Filter">
</div>
</nav>
2 changes: 1 addition & 1 deletion TWLight/users/templates/users/filter_section.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,6 @@
<div class="dropdown-divider"></div>
{% comment %}Translators: On the MyLibrary page (https://wikipedialibrary.wmflabs.org/users/my_library), this is a placeholder for an input that helps users filter collections. {% endcomment %}
<input id="collection-live-search" class="form-control form-control-sm mr-sm-2"
type="search" placeholder="{% trans 'Filter collections' %}" aria-label="Filter">
type="search" placeholder="{% trans 'Search collection descriptions' %}" aria-label="Filter">
</div>
</nav>