Skip to content

[wasm-split] Use escapes names for manifest files #8876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
aheejin wants to merge 1 commit into from
+6 −4
Closed

[wasm-split] Use escapes names for manifest files #8876

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,8 @@ Current Trunk
- Add acqrel ordering support for atomic fences (#8845). Breaks the C API;
`BinaryenAtomicFence` now takes a memory order param. Use
`BinaryenMemoryOrderSeqCst()` to preserve the original behavior.
- wasm-split's --manifest option now takes a manifest file with escaped function
names instead of unescaped ones, e.g., `foo\20bar` instead of `foo bar`.

v130
----
Expand Down
2 changes: 1 addition & 1 deletion src/tools/wasm-split/wasm-split.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -431,7 +431,7 @@ void multiSplitModule(const WasmSplitOptions& options) {
}
continue;
}
Name name = Names::escape(line);
Name name(line);
if (newSection) {
if (name.endsWith(":")) {
name = name.substr(0, name.size() - 1);
Expand Down
6 changes: 3 additions & 3 deletions test/lit/wasm-split/multi-split-escape-names.wast.manifest
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
1:
wasm::Type::getFeatures() const
wasm::Type::getFeatures\28\29\20const

2:
wasm::Literal::Literal(std::__2::array<wasm::Literal, 4ul> const&)
wasm::Literal::Literal\28std::__2::array<wasm::Literal\2c\204ul>\20const&\29

3:
std::operator<<(std::__2::basic_ostream<char, std::__2::char_traits<char>>&, wasm::Module&)
std::operator<<\28std::__2::basic_ostream<char\2c\20std::__2::char_traits<char>>&\2c\20wasm::Module&\29
Loading