Reserve preallocated room for active partitions in retention#90
Merged
Conversation
Retention previously sized the byte budget against on-disk data only, ignoring that each active (in-memory) partition can grow by up to one full segment before that segment rolls and becomes eligible for retention. Under write pressure this let the catalog overshoot its target by roughly max_segment_bytes per active partition. Subtract `max_segment_bytes * active_partitions` from the retention budget so the limit leaves space for that in-flight growth. The reserve is computed per retention check and stacks with the existing filesystem headroom. Co-Authored-By: Claude Opus 4.8 <[email protected]> Claude-Session: https://claude.ai/code/session_01Y7UYuQ5VBUQhbwpRutXvkh
imp
force-pushed
the
fmurphy/preallocate-space-per-active-partition
branch
from
d2ae95a to
75eb112
Compare
imp
approved these changes
Jun 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Retention previously sized the byte budget against on-disk data only, ignoring that each active (in-memory) partition can grow by up to one full segment before that segment rolls and becomes eligible for retention. Under write pressure this let the catalog overshoot its target by roughly max_segment_bytes per active partition.
Subtract
max_segment_bytes * active_partitionsfrom the retention budget so the limit leaves space for that in-flight growth. The reserve is computed per retention check and stacks with the existing filesystem headroom.Claude-Session: https://claude.ai/code/session_01Y7UYuQ5VBUQhbwpRutXvkh