Crisp branch

[CrislpWW2]

No description provided.

[songrenzhao]

Congrats on your first PR.
A few things that you should consider

• You are writing a lot of imperative code, can we be a bit more functional?
  • Look into usage of Array.prototype.forEach(), Array.prototype.find(), Array.prototype.map()
• You are nesting too much logic in a single function, with numerous if and else, can we make the function cleaner and easier to read?

Consider doing something below

• Read each word
• Check if current word is stopWords
• Check if current word is mealTime
• Check if current word is dates
• Check if current word is unknown

const formattedWords = words.map(word => {
  const loweredCaseWord = word.toLowerCase();
  const isStopWord = stopWordList.includes(loweredCaseWord);
  if (isStopWord) {
     /// Your logic here ...
     return { ... }
  }

  const mealTime = mealTimes.find(...); // This will return mealTIme or undefined
  const datesLog = datesLogs.find(...); // This will return dateLog or undefined
  const mealTimeOrDatesLog = mealTime ?? datesLog;

  const response = !!mealTimeOrDatesLog ? { ... } : { ... };
  return response;
})

• ?? => https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Nullish_coalescing

[songrenzhao]

• It's important to be consistent

Suggested change

	module.exports = {mealTimes, datesLog};
	module.exports = { mealTimes, datesLog };

[songrenzhao]

Suggested change

	module.exports = { stopWordList }
	module.exports = { stopWordList };

[songrenzhao]

Maybe you can break these into controllers. So it's easier to maintain in the future

Suggested change

	router.post('/parse', function (req, res) {
	const { str } = req.body;
	const parsed = parseFunction.parser(str);
	res.json(parsed);
	});
	router.post('/parse', parse);

[songrenzhao]

We can remove unnecessary comments

[songrenzhao]

This is not needed, we don't need a comment to specify EOL. A new line is enough

[songrenzhao]

• This can be extracted into its middleware. We can do something like this

router.post('/parse', formatBody, parse);

• Reason this is recommended is the concept of separation of concerns. We want to make the function as simple as possible, these types of validations can be handled before it reaches to the handler

[songrenzhao]

• We should not name a function parameter string
• string is usually a type in other languages, we should use words or other meaningful plurals

[songrenzhao]

• let is rarely recommended because we want to avoid mutability, if you believe lowerCaseWord won't be reassigned then we should use const
• Can we just do string[i].toLowerCase()

[songrenzhao]

• Seems like you are doing a look up here
• Great to see some solid understanding of iterative programming, but maybe we can leverage some built in function like Array.prototype.find()?
  • https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/find

[songrenzhao]

• mealTimes and datesLog don't share the same length
• If j = mealTimes.length - 1, then datesLog[j] will be out of bound