Skip to content

Record Kaoto forms #104 merge outcome #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
VrtxOmega merged 1 commit into from
Jul 27, 2026
Merged

Record Kaoto forms #104 merge outcome #17

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,6 +170,7 @@ The lifecycle gate is calibrated against observed upstream outcomes as well as s

- [Hermes Agent #69696](https://github.com/NousResearch/hermes-agent/pull/69696) is an open, maintainer-authored broader solution that explicitly subsumes and credits my still-open [#43834](https://github.com/NousResearch/hermes-agent/pull/43834) for independently mapping the desktop login-shell `PATH` bug family. Neither PR is counted as a merge. The event demonstrates the difference between an aging point patch and a diagnosis that survives into a better system-wide design.
- [Karakeep #2864](https://github.com/karakeep-app/karakeep/pull/2864) merged on July 26, 2026 and is scheduled for the next release. It was a one-line, component-local overflow fix for tall screenshot previews, validated by the project's format, lint, typecheck, test, diff-check, and pre-commit gates. The long review queue did not broaden the patch or produce a requested technical rework.
- [Kaoto forms #104](https://github.com/KaotoIO/forms/pull/104) merged into `1.x` on July 27, 2026 after project-member approval. The two-file fix traced a downstream Kaoto empty-state report to the owning shared forms package, removed an impossible “switch to All” instruction when `All` was already selected, and added focused regression coverage. The review produced no requested technical rework.

These are author-run contribution outcomes, not maintainer endorsements of PCF or proof of product validity. The detailed evidence and retained gates are recorded in the [Upstream Contribution Learning Ledger](docs/UPSTREAM_CONTRIBUTION_LEDGER.md).

Expand Down
7 changes: 4 additions & 3 deletions docs/UPSTREAM_CONTRIBUTION_LEDGER.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,15 +118,16 @@ Before any public PR or comment, the contribution lane must pass these checks:
- Gate retained: for bucket issues, choose exactly one current warning class, prove it on current `staging`, leave unrelated warning classes for separate PRs, and avoid claiming the whole bucket is closed.
- Follow-up: after merge, left one short thank-you/provenance comment explaining that PCF helped keep the Amber contribution narrow, check overlap, and verify generated output before opening.

### 2026-06-11 - Open PR - `KaotoIO/forms#104`
### 2026-07-27 - Accepted - `KaotoIO/forms#104`

- PR: <https://github.com/KaotoIO/forms/pull/104>
- Related issue: <https://github.com/KaotoIO/kaoto/issues/3281>
- Outcome: opened as a narrow bugfix PR against the `1.x` forms branch; initial GitHub readback reported it as open, mergeable, and not draft. CodeRabbit review was pending at closeout.
- Outcome: merged into `1.x` at `2026-07-27T13:58:06Z` after project-member approval; the direct VrtxOmega contribution landed as merge commit `f76fee10dfd2cf84d1c209be41e8f9203f8c8339`.
- What was wanted: a `bug` + `good first issue` + `help wanted` empty-state copy fix where the form already on the `All` tab should not tell the user to switch to `All`.
- What changed: `NoFieldFound` now keeps the `Switch to All tab` action for filtered `Required` / `Modified` tabs, but shows a plain no-results message when `All` is already selected.
- Evidence: `KaotoIO/kaoto#3283` was already merged and intentionally scoped to adding REST DSL search, while `#3281` was opened separately for this shared forms-library message. `@kaoto/[email protected]` and `1.7.2` had identical `NoFieldFound` output, so the fix belonged in `KaotoIO/forms` rather than a Kaoto app dependency bump.
- Evidence: `KaotoIO/kaoto#3283` was already merged and intentionally scoped to adding REST DSL search, while `#3281` was opened separately for this shared forms-library message. `@kaoto/[email protected]` and `1.7.2` had identical `NoFieldFound` output, so the fix belonged in `KaotoIO/forms` rather than a Kaoto app dependency bump. The merged diff remained limited to `NoFieldFound.tsx` and its focused regression test; CodeRabbit generated no actionable review comments.
- Gate retained: when a downstream app issue points at a shared library component, verify the library source/release branch first and open the PR in the owning repo/release line instead of patching around the symptom in the app.
- Follow-up: after merge, left one short thank-you/provenance comment explaining that the contribution workflow helped trace the report to the shared package and keep the patch limited to the All-tab empty state.

### 2026-06-11 - Open PR - `StingraySoftware/stingray#978`

Expand Down