Include lyrics in dump - #2172
Closed
maxkagamine wants to merge 3 commits into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per discussion in #dev-questions, I've updated this PR to reflect @FinnRG's proposal of having a separate "non-free" dump that includes lyrics.
I refactored the dumper a bit so that it can create both archives in one go without having to query the whole db twice (will need to be tested). I've also incorporated @Hans5958's change to include PV reprints (#2166).
This would be useful for things like batch retagging (to avoid hammering the API), data analysis, as well as general preservation in case anything happens to VocaDB.
It would probably be a good idea to include a LICENSE.txt file in the zip that links back to the license page.