Log instead of assert in InstanceCounter destructor#84
Open
danielraffel wants to merge 1 commit into
Open
Conversation
When a host application calls exit(), static destructors run before plugin editors have been cleaned up. The InstanceCounter singleton destructor sees a non-zero count and hits VISAGE_ASSERT, crashing the host during shutdown. This isn't a real leak — the host just didn't give the plugin a chance to destroy its UI before tearing down the process. Replace the assertion with a VISAGE_LOG so it's still visible during debugging but doesn't crash the host.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a host application calls
exit(), static destructors run before plugin editors have been cleaned up. TheInstanceCountersingleton destructor sees a non-zero count and hitsVISAGE_ASSERT, crashing the host during shutdown.This isn't a real leak — the host just didn't give the plugin a chance to destroy its UI before tearing down the process. This replaces the assertion with
VISAGE_LOGso it's still visible during debugging but doesn't crash the host.We've seen this in practice with Ableton Live, which calls
exit()on quit rather than cleanly destroying plugin editors first.Discovered while working on a macOS JUCE audio plugin that uses Visage for its UI. This PR was put together with the help of Claude. Completely understand if you'd prefer to close this — just wanted to share the fix since we've been patching around it on our end whenever we update Visage.