refactor(html5rdp): restructure connection options and redirection se…#21
Merged
Conversation
Refactor d7a5948 nested the extra params dict (nla/verify_ssl under options, audio/mic/clipboard under redirections). Update the get_link tests to read the nested keys instead of the old flat ones.
dkmstr
approved these changes
Jun 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors how redirection-related options are structured in the
get_linkmethod ofsrc/uds/transports/HTML5RDP/html5rdp.py. The main change is to group clipboard, audio, microphone, and webcam redirection settings under a newredirectionsdictionary, improving code organization and aligning with expected gateway data structures.Redirection settings refactor:
allow_clipboard,allow_audio, andallow_mic(microphone) options into a newredirectionsdictionary, instead of having them as top-level keys.redirectionsdictionary, ensuring consistent grouping of all redirection-related settings.Other structural improvements:
redirections.webcaminstead ofconn_data.webcam.