stubbed out the carpet and lily pad collision fixes for Mojang 1.20.5…#99
Open
Wolf1098 wants to merge 2 commits into
Open
stubbed out the carpet and lily pad collision fixes for Mojang 1.20.5…#99Wolf1098 wants to merge 2 commits into
Wolf1098 wants to merge 2 commits into
Conversation
…+ (26.x) since the SHAPE field is now static final and cannot be modified at runtime. The code now logs a warning and skips the collision fix for these versions. switched to using net.minecraft.world.level.block.LadderBlock instead of net.minecraft.world.level.block.BlockLadder for Mojang 1.20.5+ (26.x) since the class was renamed in that version.
Author
|
As expected the ladders work, the carpet and the lillypads are a tar trap |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…+ (26.x) since the SHAPE field is now static final and cannot be modified at runtime. The code now logs a warning and skips the collision fix for these versions.
switched to using net.minecraft.world.level.block.LadderBlock instead of net.minecraft.world.level.block.BlockLadder for Mojang 1.20.5+ (1.21.x/26.x) since the class was renamed in that version.