Fix launch canKill inversion and tray bugs#711
Merged
Conversation
- DiffRunner: the sync launch path passed `tool.IsMdi` instead of `!tool.IsMdi` as `canKill` on the already-running and max-instance paths, diverging from the async path. For MDI tools (VS Code, Cursor, Visual Studio, Araxis) this could make the tray kill the shared editor when a diff is accepted/discarded; for non-MDI tools it left diff windows orphaned. Compute `canKill` once so the paths can't drift. - Program.ReBindKeys: the "Accept Open" hotkey was registered under KeyBindingIds.AcceptAll, so configuring both it and "Accept All" silently disabled "Accept All". Route bindings through a single BuildKeyBindings mapping with the correct id. - SolutionDirectoryFinder: the cached-prefix match had no directory-separator boundary, so a file under "AppTests" resolved to a cached "App" solution. Add a boundary check, make it case-insensitive, and prefer the nearest enclosing directory. - PiperClient: the async sends accepted a cancellation token but never used it. Thread it through connect/write and let cancellation surface to the caller instead of being logged as a send failure. - ProcessEx.KillAndDispose: the error handlers read Id/MainModule after the kill, which can throw and escape the method. Capture the process description up front. - FileEx.SafeDeleteDirectory threw on a temp directory that contained only empty sub-directories (non-recursive delete). Delete recursively and rename the misleading `IsEmptyDirectory` (which only checked for files) to `ContainsFiles`. Add regression tests for each.
This was referenced Jul 10, 2026
Bump DiffEngine from 19.3.1 to 19.3.2
NServiceBusCommunity/NServiceBus.Community.HandlerOrdering#357
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tool.IsMdiinstead of!tool.IsMdiascanKillon the already-running and max-instance paths, diverging from the async path. For MDI tools (VS Code, Cursor, Visual Studio, Araxis) this could make the tray kill the shared editor when a diff is accepted/discarded; for non-MDI tools it left diff windows orphaned. ComputecanKillonce so the paths can't drift.IsEmptyDirectory(which only checked for files) toContainsFiles.Add regression tests for each.