feat: support first page / last page on pagination#5683
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: 6884798 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Greptile SummaryThis PR adds first-page and last-page controls to pagination. The main changes are:
Confidence Score: 5/5This looks safe to merge.
Important Files Changed
Reviews (2): Last reviewed commit: "feat: support first page / last page on ..." | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
| <PaginationButton onClick={() => goToPageByIndex(0)}> | ||
| <Icon css={styles.iconArrow} name="doubleChevronLeft" /> |
There was a problem hiding this comment.
When pagination has more than one page, this new first-page control renders as a button whose only child is an SVG with no accessible name. Screen readers and voice-control users will hear or target an unlabeled button instead of a “go to first page” action; the button needs a localized aria-label on the control.
Context Used: Ensure the rules defined in the files under .claud... (source)
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
| <PaginationButton onClick={() => goToPageByIndex(pagesCount - 1)}> | ||
| <Icon css={styles.iconArrow} name="doubleChevronRight" /> |
There was a problem hiding this comment.
When pagination is not on the last page, this new last-page control renders as a button whose only child is an SVG with no accessible name. Screen readers and voice-control users will hear or target an unlabeled button instead of a “go to last page” action; the button needs a localized aria-label on the control.
Context Used: Ensure the rules defined in the files under .claud... (source)
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
|
@greptile review again |
2 participants
Jira ticket(s)
VPD-1532
Changes