Range-based identical protein variants#43
Closed
afrubin wants to merge 2 commits into
Closed
Conversation
bencap
approved these changes
Apr 14, 2026
bencap
left a comment
bencap
left a comment
Contributor
There was a problem hiding this comment.
lgtm from visual inspection. My only suggestion would be to wrap the new expected key lists in a sorted() call for consistency, but not blocking since I doubt the alphabet will change.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for range-bases identical protein variants (e.g. "p.Glu12_Gly14="), which is needed to combine multiple wild-type sequences in cases where each tile has a separate wild-type measurement (e.g. TSC2 meta-analysis).
Also closes #37