test: Expand payjoin cli integration test coverage - #136
Open
ValeraFinebits wants to merge 3 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Expands payjoin-cli integration coverage and isolates integration tests into the CI workflow introduced by dependency PR #129.
Changes:
- Adds CLI scenarios for relay failures, invoice states, cold-wallet change, confirmations, expiry, and persisted sessions.
- Improves CLI diagnostics, transaction detection, and test helpers.
- Ensures receiver poller cancellation completes cleanly.
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
PayjoinReceiverPoller.cs |
Handles cancellation while awaiting timer ticks. |
PayjoinReceiverPollerTests.cs |
Verifies poller shutdown completion. |
PayjoinReceiverTestHelper.cs |
Returns close-requested session state. |
PayjoinInvoiceTestHelper.cs |
Strengthens invoice transition assertions. |
PayjoinCliPayer.cs |
Adds CLI session commands and diagnostics. |
PayjoinCliIntegrationTestSupport.cs |
Verifies persisted successful sessions. |
PayjoinCliIntegrationTests.cs |
Adds expanded CLI integration scenarios. |
.github/workflows/package.yml |
Pins updated workflow actions. |
.github/workflows/integration.yml |
Adds scheduled/manual integration CI. |
.github/workflows/codeql.yml |
Pins updated CodeQL actions. |
.github/workflows/build.yml |
Restricts standard CI to unit tests. |
.github/actions/prepare-ci-build/action.yml |
Pins build-setup actions. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
ValeraFinebits
force-pushed
the
test/Expand-payjoin-cli-integration-test-coverage
branch
2 times, most recently
from
August 15, 2026 14:56
47a0db5 to
49efcce
Compare
ValeraFinebits
force-pushed
the
test/Expand-payjoin-cli-integration-test-coverage
branch
from
August 15, 2026 15:28
c48c5fa to
9be69af
Compare
ValeraFinebits
marked this pull request as ready for review
August 15, 2026 15:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is based on #129 and should be merged only after #129.
Summary
Expands
payjoin-cliintegration coverage and moves integration tests into a dedicated CI workflow.PayjoinReceiverPollershuts down cleanly while waiting for its next tick.