fix(cli): honor explicit alternate device ports#126
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--device <ip> --port <port>against the matching discovered address before stale same-IP entriesFixes #125
Root cause
The CLI registry resolved plain IP queries by returning the first same-IP device before considering the global
--portoverride. A paired alternate-port browser could therefore be discovered and stored correctly, but later commands still selected a stale:8420entry or fell back to a direct id without the stored token.Validation
pnpm --filter @unlikeotherai/kelpie-shared build && pnpm --filter @unlikeotherai/kelpie exec vitest run tests/discovery/registry.test.ts tests/commands/program.test.ts tests/client/http-client.test.ts tests/auth/token-store.test.tspnpm lint && pnpm build && pnpm testgit diff --check