feat: Mute melody synth in vocal effect modes#112
Open
nathansbradshaw wants to merge 6 commits into
Open
Conversation
In Vocode and Harmony modes, silence synth output on the melody channel (MIDI ch 1) while keeping it in the pitch-correction frequency cache. This allows the processed voice to be heard without the synth playing over it. Also fixes: - Prevent drum notes (channel 9) from affecting pitch control targets - In PitchControl mode, ignore MIDI note frequencies as pitch-correction targets to avoid force-tuning voice to held notes - Improve drum velocity response by compressing to 0.5..1.0 range and increase makeup gain from 0.75 to 2.5
Adds independent volume controls for voice, melody, and drums with power-loss-safe storage in QSPI flash. Features include dual-slot storage with generation-based recovery, CRC32 validation, and automatic save-after-idle (2 seconds) for changed settings. Volumes are restored on startup, and the master volume range is extended from 0-10 to 0-20. Also optimizes the debug profile for binary size by disabling assertions and overflow checks.
nathansbradshaw
force-pushed
the
feat-better-voice-with-midi
branch
from
July 17, 2026 19:08
df6ddf2 to
8b14f9f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Vocode and Harmony modes, silence synth output on the melody channel (MIDI ch 1) while keeping it in the pitch-correction frequency cache. This allows the processed voice to be heard without the synth playing over it.
Also fixes: