Add vibrato on/off toggle & increase dead zone#18
Open
nathansbradshaw wants to merge 2 commits into
Open
Conversation
nathansbradshaw
commented
Jul 17, 2026
nathansbradshaw
commented
Collaborator
- Add VIBRATO_SETTING menu item to enable/disable vibrato via CC1 (off by default)
- Increase VIBRATO_DEAD_ZONE from 30 to 100 to prevent accidental triggering
- Display vibrato as ON/OFF instead of numeric value in settings menu
- Only send vibrato CC1 when enabled and settings menu is closed
- Fix Embed.toml chip identifier to "STM32H750VBTx"
- Add LM317L linear regulator circuit to schematic for clean 3.3V rail
- Update .gitignore to exclude KiCad temporary files
- Add VIBRATO_SETTING menu item to enable/disable vibrato via CC1 (off by default) - Increase VIBRATO_DEAD_ZONE from 30 to 100 to prevent accidental triggering - Display vibrato as ON/OFF instead of numeric value in settings menu - Only send vibrato CC1 when enabled and settings menu is closed - Fix Embed.toml chip identifier to "STM32H750VBTx" - Add LM317L linear regulator circuit to schematic for clean 3.3V rail - Update .gitignore to exclude KiCad temporary files
Implement dual-slot QSPI flash storage for settings with CRC validation to safely persist changes across power cycles. Add emergency factory reset feature: holding Settings (HE74) and All Notes Off (HE76) keys together for 3 seconds triggers a reset to defaults. Add "RESET DEFAULTS" menu item for user-initiated factory reset. Settings are automatically saved when the settings menu closes. Load saved settings on boot, falling back to defaults if flash is empty or corrupted. Change default melody channel from 0 to 2.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.