Skip to content

feat(scanner-tuning): add suppression lifecycle model and drift evidence gates (#2724)#2725

Closed
zeroknowledge0x wants to merge 1 commit into
UnitOneAI:mainfrom
zeroknowledge0x:bounty/2724-REVIEW-scanner-tuning-add-suppression-
Closed

feat(scanner-tuning): add suppression lifecycle model and drift evidence gates (#2724)#2725
zeroknowledge0x wants to merge 1 commit into
UnitOneAI:mainfrom
zeroknowledge0x:bounty/2724-REVIEW-scanner-tuning-add-suppression-

Conversation

@zeroknowledge0x

Copy link
Copy Markdown

Summary

Adds a suppression lifecycle model and drift evidence gates to the scanner-tuning skill. The current skill correctly warns against blind suppressions but lacks a positive model for safe suppressions and automated gates to catch when safe suppressions become dangerous after environment drift.

Business impact: Without lifecycle governance, suppressions silently accumulate as blind spots. A suppression that was safe in 2024 (narrow scope, evidence-backed) becomes a hidden true positive in 2026 when the service moves to internet-facing or the scanner plugin is updated. This PR prevents that class of silent risk accumulation.

Changes

Suppression Lifecycle Model (Step 2)

  • Suppression Risk Tiers: Safe → Moderate → Risky → Dangerous classification based on scope, evidence, owner, expiry, and re-open triggers
  • Safe Suppression Requirements: Mandatory record format with 12 fields including named owner, expiry date (never null), evidence sources, and auto-reopen triggers
  • Critical disposition enforcement: "Confirmed false positive" and "compensated risk" are explicitly distinct — a WAF-blocked RCE is NOT a false positive

Drift Evidence Gates (Step 2)

Six automated gates that force re-evaluation when the environment drifts:

  1. Suppression age gate — flag expired and orphaned suppressions
  2. Plugin update gate — re-evaluate when scanner detection logic changes
  3. Asset exposure gate — re-evaluate on zone migration / public IP change
  4. Package change gate — re-evaluate on version or installation change
  5. Compensating control gate — reopen immediately if control is removed
  6. Quarterly review gate — mandatory re-review cycle for all suppressions

Output Format additions

  • Suppression Inventory table with tier classification, orphan/expiry/misclassification counts
  • Drift Gate Audit table with per-suppression verdict (Keep/Re-evaluate/Reopen)

Updated sections

Closes #2724

…nce gates

Addresses review feedback from UnitOneAI#2724:

- Add Suppression Risk Tiers (Safe/Moderate/Risky/Dangerous) to distinguish
  evidence-backed, time-bounded, owner-approved suppressions from blanket
  indefinite exclusions
- Add Safe Suppression Requirements with mandatory fields: named owner,
  expiry date, scope, evidence, and auto-reopen triggers
- Add Drift Evidence Gates (6 gates): suppression age, plugin update, asset
  exposure change, package change, compensating control status, quarterly review
- Add Suppression Inventory and Drift Gate Audit to Output Format sections
- Enforce critical distinction: compensated risk != confirmed false positive
- Update FP Validation Workflow disposition to require lifecycle compliance
- Update Prompt Injection Safety Notice with suppression lifecycle constraints
- Add pitfalls UnitOneAI#6 (indefinite suppressions) and UnitOneAI#7 (compensated risk as FP)

Closes UnitOneAI#2724
@github-actions github-actions Bot added the needs-approved-issue PR has no linked maintainer-approved issue label Jun 17, 2026
@github-actions

Copy link
Copy Markdown

Thanks for the submission! 🙏 SecuritySkills is now issue-first: contributions need a linked issue that a maintainer has marked approved before a PR is opened.

Please open an issue describing the skill, wait for the approved label, then reopen this PR with Closes #<issue> in the description. The PR template lists everything we'll look for (including an independently runnable reproduction).

@github-actions github-actions Bot closed this Jun 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-approved-issue PR has no linked maintainer-approved issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[REVIEW] scanner-tuning: add suppression lifecycle and drift evidence gates

1 participant