feat(secure-code-review): add HTTP parser boundary and request smuggling review gates#1289
Closed
RanuK12 wants to merge 1 commit into
Closed
feat(secure-code-review): add HTTP parser boundary and request smuggling review gates#1289RanuK12 wants to merge 1 commit into
RanuK12 wants to merge 1 commit into
Conversation
…ing review gates Adds Step 2.4 covering CWE-444 (Inconsistent Interpretation of HTTP Requests) to the secure-code-review skill. Addresses #1174. Changes: - Add section 2.4 with evidence table, vulnerable/benign patterns, and checklist - Cover Nginx-to-Node.js proxy forwarding, Express raw-body desync, HTTP/2-to-HTTP/1 downgrade, serverless adapter body re-encoding, duplicate Content-Length across proxy layers, and global webhook raw-body - Add benign examples: Go strict server, route-scoped raw body, proper Nginx/HAProxy/Cloudflare configuration - Add Boundary Evidence field to findings classification - Add CWE-444 to supplemental coverage table - Add false-positive guidance (pitfall #6): require parser mismatch evidence - Add references: OWASP WSTG, CWE-444, RFC 9110, Node.js HTTP docs - Bump version to 1.0.1 - Add test cases: 6 vulnerable + 5 benign code samples
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds Step 2.4: HTTP Parser Boundary and Request Smuggling Review to the
secure-code-reviewskill, addressing #1174. This closes a critical coverage gap: the skill previously had no gate for HTTP request smuggling / parser-boundary issues, leaving two failure modes uncovered.Skill Modified
secure-code-reviewskills/appsec/secure-code-review/What This PR Fixes
False Positive Reduction
The skill now explicitly requires parser mismatch evidence before classifying CWE-444. Large headers, long timeouts, raw-body access, or a reverse proxy in the path are NOT findings by themselves. A concrete false-positive example (Go
http.ServerwithReadHeaderTimeout+MaxHeaderBytes, no proxy) is documented as "Informational at most."New Coverage (Step 2.4)
Transfer-EncodingContent-Lengthheaders across proxy layers (HAProxy)http.Serverwith strict parser and bounded limits (no proxy)Test Cases Added
tests/vulnerable/— 6 code samples that SHOULD trigger Step 2.4 (CWE-444)tests/benign/— 5 code samples that should NOT be flagged as CWE-444Acceptance Criteria Mapping
Validation
Bounty Info
I have read and agree to the CONTRIBUTING.md bounty terms.
Bounty tier: Moderate ($100) -- new edge case coverage, FP reduction with evidence
Preferred payment: PayPal (details available privately after acceptance)
Closes #1174